build: Re-architected to prepare for shared library#98
Merged
stanleyjones merged 5 commits intoliftedinit:mainfrom Nov 8, 2022
Merged
build: Re-architected to prepare for shared library#98stanleyjones merged 5 commits intoliftedinit:mainfrom
stanleyjones merged 5 commits intoliftedinit:mainfrom
Conversation
stanleyjones
commented
Nov 7, 2022
Contributor
Author
stanleyjones
left a comment
stanleyjones
left a comment
There was a problem hiding this comment.
Just pointing out the non-renaming parts of this PR.
| <IconButton | ||
| key={social.provider} | ||
| aria-label={social.provider} | ||
| icon={<social.Icon />} |
Contributor
Author
There was a problem hiding this comment.
This section is the only logical change in this pull request, the rest is all renaming imports. For some reason, <social.Icon /> wasn't working anymore after changing the paths to the shared component folder. I'll take a look at this again once we've got everything pulled into a separate project.
Comment on lines
-1
to
-3
| import create from "zustand"; | ||
| import { persist } from "zustand/middleware"; | ||
| import localforage from "localforage"; |
Contributor
Author
There was a problem hiding this comment.
Alberto's style guide (see .prettierrc) disables semi-colons but somehow this file had them.
This was referenced Nov 8, 2022
hansl
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sister PR to liftedinit/gwen#8.
Still WIP as e2e tests are failing — which is a great opportunity for me to learn how these e2e tests really work.