Skip to content
This repository was archived by the owner on Jan 26, 2023. It is now read-only.

Conversation

@fmorency
Copy link
Contributor

@fmorency fmorency commented Sep 6, 2022

Reverts #226

This PR was not ready to be merged.

  • Resiliency test "Network is consistent with 1 node down" is consistently failing locally
  • Resiliency test "Node can catch up" is consistently failing locally
  • Need to replace smol with tokio runtime (Replace smol with tokio runtime #228)

More investigation and testing are required.

@fmorency fmorency requested review from Denommus and hansl September 6, 2022 14:20
@fmorency fmorency self-assigned this Sep 6, 2022
@fmorency fmorency added the bug Something isn't working label Sep 6, 2022
@fmorency
Copy link
Contributor Author

fmorency commented Sep 6, 2022

I tested the resiliency tests locally, and they work again.

@fmorency fmorency merged commit f262e18 into main Sep 6, 2022
@fmorency fmorency deleted the revert-226-update-many-rs-id-clien branch September 6, 2022 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants