Missing blockchain endpoints #249
Conversation
Codecov Report
@@ Coverage Diff @@
## main #249 +/- ##
==========================================
- Coverage 76.85% 75.76% -1.09%
==========================================
Files 43 43
Lines 7975 8089 +114
==========================================
Hits 6129 6129
- Misses 1846 1960 +114
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ing-blockchain-endpoints
hansl
left a comment
hansl
left a comment
There was a problem hiding this comment.
Can I have some tests please?
|
|
||
| // The default query returns an error (TM 0.35) | ||
| // Return all blocks | ||
| // TODO: Test on TM 0.34 and report an issue in TM-rs if reproducible |
There was a problem hiding this comment.
Is this TODO blocking this PR? If not, add an issue and link it here.
There was a problem hiding this comment.
Not blocking. I didn't have time to test it on 0.34; thus not opened an issue yet.
See PR description above.
@tantommy can you comment on the tests you made on your side? |
hansl
left a comment
hansl
left a comment
There was a problem hiding this comment.
Approving conditional to @tantommy approval too (since he's doing QA on this issue).
|
i have tested these endpoints and they are working as expected. lgtm |
4 participants
Implements
Still need to write tests for all of those, but some introspection tooling in
manywould be needed; I reaaaally don't want to do that usinggrepandsed.I asked @tantommy to help with the testing.
Depends on liftedinit/many-rs#208