This repository was archived by the owner on Jan 26, 2023. It is now read-only.
Add semver to the version of many-abci #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmorency
approved these changes
Oct 6, 2022
Contributor
fmorency
left a comment
fmorency
left a comment
There was a problem hiding this comment.
LGTM assuming the comment is addressed. Thanks!
| tendermint-rpc = { version = "0.24.0-pre.2", features = [ "http-client" ] } | ||
| tendermint-proto = "0.24.0-pre.2" | ||
| tokio = { version = "1.13.0", features = [ "full" ] } | ||
| tracing = "0.1.28" |
Contributor
There was a problem hiding this comment.
According to the vergen documentation, you are missing build = "build.rs" in the [package] section of this file.
That being said, it seems to work anyway.
hansl
force-pushed
the
add-vergen-to-abci
branch
from
aacdce4 to
05d6466
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make sure we get at least the SHA of the commit that was used for production.