Skip to content
This repository was archived by the owner on Jan 26, 2023. It is now read-only.

Conversation

@fmorency
Copy link
Contributor

@fmorency fmorency commented Oct 7, 2022

  • Add allow-addr bats tests
  • Refactor bats test

Fixes #258

@fmorency fmorency added the enhancement New feature or request label Oct 7, 2022
@fmorency fmorency requested a review from hansl October 7, 2022 14:11
@fmorency fmorency self-assigned this Oct 7, 2022
- Add allow-addr bats tests
- Refactor bats test
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, love the bats cleanup

@hansl
Copy link
Contributor

hansl commented Oct 11, 2022

I'm working on a spec proposal to make those crazy modules disappear, but this is good for now.

@fmorency fmorency merged commit 367cb3f into liftedinit:main Oct 12, 2022
@fmorency fmorency deleted the fmorency/enh-258-allow-addr-ledger-kvstore branch October 12, 2022 12:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allowlist needs to also happen in ledger/kvstore

2 participants