Skip to content
This repository was archived by the owner on Jan 26, 2023. It is now read-only.

Conversation

@fmorency
Copy link
Contributor

Description

macOS runs Docker containers as the current user, and Linux runs them as root. This PR fixes the Docker environment to behave correctly under Linux.

Related Issue

Fixes #69

Testing

  • DOCKER_BUILDKIT=1 make start-docker-compose
  • make chaos
  • make start-all-nodes
  • make stop-node

Breaking Changes (if applicable)

Screenshots (if applicable)

Checklist:

  • I have read and followed the CONTRIBUTING guidelines for this project.
  • I have added or updated tests and they pass.
  • I have added or updated documentation and it is accurate.
  • I have noted any breaking changes in this module or downstream modules.

@fmorency fmorency added the bug Something isn't working label May 11, 2022
@fmorency fmorency requested review from brohamgoham and hansl May 11, 2022 13:55
@fmorency fmorency self-assigned this May 11, 2022
@fmorency
Copy link
Contributor Author

@hansl @brohamgoham please test that this works on macOS. Thanks!

@fmorency fmorency mentioned this pull request May 11, 2022
@hansl
Copy link
Contributor

hansl commented May 11, 2022

Let me test it locally to make sure it still works on a mac.

@fmorency fmorency merged commit 9e29f1a into liftedinit:main May 11, 2022
@fmorency fmorency deleted the fmorency/bug-69-docker-linux branch May 11, 2022 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix docker build/run on Linux

2 participants