This repository was archived by the owner on Jan 26, 2023. It is now read-only.
IdStore feature and tests #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature complete
Current `many-rs` head breaks `many-framework`
hansl
reviewed
May 26, 2022
hansl
reviewed
May 26, 2022
hansl
approved these changes
May 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependant on liftedinit/many-rs#89
Fixes #74
Keeping this PR a draft until PR in
many-rsis merged and this PR updated.NOT tested on ABCI. I plan on implementing BATS test for ABCI testing.
I would also like to know if there's a better way of implementing the
generate_entropy()stuff for test vs not test.I didn't split the code into other modules. We can do that during the refactoring.