Do not lift functions that are not in the JSON spec#102
Merged
artemdinaburg merged 2 commits intomasterfrom Feb 16, 2021
Merged
Do not lift functions that are not in the JSON spec#102artemdinaburg merged 2 commits intomasterfrom
artemdinaburg merged 2 commits intomasterfrom
Conversation
Contributor
artemdinaburg
left a comment
artemdinaburg
left a comment
There was a problem hiding this comment.
It looks good I would just like some more explanation about exactly what the change are doing in comments.
pgoodman
suggested changes
Feb 12, 2021
pgoodman
reviewed
Feb 16, 2021
| // with only native functions. | ||
| OptimizeFunction(entry.native_to_lifted); | ||
|
|
||
| // The ritual is done. |
pgoodman
approved these changes
Feb 16, 2021
pgoodman
added a commit
that referenced
this pull request
Feb 24, 2021
* Added support for remill kCategoryConditionalFunctionReturn, kCategoryConditionalIndirectJump, kCategoryConditionalDirectFunctionCall, kCategoryConditionalIndirectFunctionCall * Updated case statement * Remove Python2.7 support (#104) * Removes any mention of python2 * Removes more mentions of python2 * IDA: Add a simple action to generate spec files (#94) * IDA: Add a simple action to generate spec files * docs: Update the example instructions * Do not lift functions that are not in the JSON spec (#102) * Modifies lifting to ignore functions that do not have mapped bytes in the spec * Moves byte existence and executability check to LifFunction() and adds comments * Handling of Named Type references (#99) * Handling of named references Fix the handling of type cache and read bytes from memory * review changes * Add vector type lifting * add remill compat header for vector type Co-authored-by: AkshayK <akshay.kumar@octolabs.io> * Refactor the CMake project (#101) * CMake: Refactor * CMake: Update the copyright and license headers * CMake: Refactor * CMake: Refactor * Misc: Remove unused remill_commit_id file * CMake: Refactor * CMake: Refactor * CMake: Refactor * CMake: Refactor * docs: Update the dependencies in the README * CI: Update the GitHub Actions workflow * CI: Update the GitHub Actions workflow * CI: Update the GitHub Actions workflow * Packaging: Add DEB/RPM/TGZ for Linux, TGZ for macOS * CI: Automatically create a release when pushing a tag * CI: Include tags when obtaining version information * CI: Automatically abort stale workflows * CMake: Refactor * CI: Disable shallow clone to fix version detection * CI: Fix Python packaging * CMake: Refactor * CI: Update the release generator * CMake: Only install to system packages if not doing a dev install (#109) * Update build.yml (#112) Limit MacOS to LLVM 11 since we have a limited number of MacOS runners. * Add TypeCache for bn type lookup (#108) Adding assert to convert type function * CMake: Update default settings, fix packaging issue (#111) - Enables the tests and the install target in the default configuration - Fixes an issues with packaging, which didn't work correctly due to how DESTDIR was handled * Fix ce replace bug (#110) * Fixes a use of replaceAllUsesOf * Move the binja_var_none_type test to should-be passing. Also, make all stack frames packed, as the way the structure types are constructed assumes every element is adjacent in memory, with i8s explicitly filling gaps * Give __anvill_reg_XXX variables a default initializer to make compiling bitcode possible. Get rid of overly eager, evil optimization that tries to load constants from memory into allocas. Add instcombine to the set of optimizations for folding goodness * Adds a --print_registers_before_instuctions option to inject printfs into the bitcode to dump all address-sized integer registers to stdout before each instruction * Move binja_var_non_type back into failing tests for now Co-authored-by: Carson Harmon <carsonharmon@protonmail.com> * Fix crash array size, unsupported reg, missing data var (#117) * fix crash due to array size and unsupported reg * Fixed assertion failure triggered in ret0.json Co-authored-by: Peter Goodman <peter.goodman@gmail.com> * Fix bytesequence and copypasta (#116) * Fix bytesequence and copypasta issues * Do variable references again * Update Program.h Useless change to force CI :-P Co-authored-by: Peter Goodman <peter@trailofbits.com> * Formats files and sets internal linkage to `__anvill_reg` globals (#118) * CI: Update asset names when handling tags (#115) * CI: Switch to the more reliable macOS 10.15 workers (#120) * CI: Use a single job to publish releases (#122) * CI: Automatically generate the release changelog (#123) * Updated VisitConditionalDirectFunctionCall and VisitConditionalIndirectJump * Delay slot fixes Co-authored-by: Marek Surovič <marek.surovic@gmail.com> Co-authored-by: Alessandro Gario <5714290+alessandrogario@users.noreply.github.com> Co-authored-by: kumarak <iit.akshay@gmail.com> Co-authored-by: AkshayK <akshay.kumar@octolabs.io> Co-authored-by: Artem Dinaburg <artem@trailofbits.com> Co-authored-by: Peter Goodman <peter@trailofbits.com> Co-authored-by: Carson Harmon <carsonharmon@protonmail.com> Co-authored-by: Peter Goodman <peter.goodman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies lifting to ignore functions that do not have mapped bytes in the JSON spec.