Skip to content

Conversation

@ekilmer
Copy link
Collaborator

@ekilmer ekilmer commented May 9, 2023

DO NOT MERGE UNTIL #1018 passes

New naming scheme appends -v# to the image name. The tag part is not changed

Removed Docker Hub pushes. Now we use ghcr.io for both images.

Use GCC for cross-compilation on Linux because Ubuntu and vcpkg have better support for cross-compilation when using GCC

Ubuntu and vcpkg better support using GCC for cross compilation
@ekilmer ekilmer force-pushed the ekilmer/version-docker-images branch 4 times, most recently from d8a6e27 to 2cbe78d Compare May 9, 2023 17:05
@ekilmer ekilmer force-pushed the ekilmer/version-docker-images branch from 2cbe78d to f788277 Compare May 9, 2023 17:08
@ekilmer ekilmer marked this pull request as ready for review May 17, 2023 18:33
@ekilmer ekilmer requested a review from Ninja3047 as a code owner May 17, 2023 18:33
@ekilmer ekilmer mentioned this pull request May 17, 2023
3 tasks
Copy link
Collaborator

@Ninja3047 Ninja3047 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit

ekilmer added 2 commits May 17, 2023 14:44
ghcr.io is now available for unauthenticated pulls
@ekilmer ekilmer requested a review from Ninja3047 May 17, 2023 19:13
@ekilmer
Copy link
Collaborator Author

ekilmer commented May 17, 2023

Oh wait. Hmmmm

Successfully tagged ghcr.io/lifting-bits/cxx-common/test-ekilmer_version-docker-images-vcpkg-builder-ubuntu-v2:20.04
WARNING! Using -*** the CLI is insecure. Use --password-stdin.
WARNING! Your password will be stored unencrypted in /home/runner/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

Login Succeeded
The push refers to repository [ghcr.io/lifting-bits/cxx-common/test-ekilmer_version-docker-images-vcpkg-builder-ubuntu-v2]
81e69031f664: Preparing
847cbbfcd137: Preparing
6f37ca73c74f: Preparing
unauthorized: unauthenticated: User cannot be authenticated with the token provided.
The push refers to repository [ghcr.io/lifting-bits/cxx-common/test-ekilmer_version-docker-images-vcpkg-builder-ubuntu-v2]
81e69031f664: Preparing
847cbbfcd137: Preparing
6f37ca73c74f: Preparing
unauthorized: unauthenticated: User cannot be authenticated with the token provided.
The push refers to repository [ghcr.io/lifting-bits/cxx-common/test-ekilmer_version-docker-images-vcpkg-builder-ubuntu-v2]
81e69031f664: Preparing
847cbbfcd137: Preparing
6f37ca73c74f: Preparing
unauthorized: unauthenticated: User cannot be authenticated with the token provided.
Sending build context to Docker daemon  5.632kB

@ekilmer ekilmer merged commit 328e762 into master May 17, 2023
@ekilmer ekilmer deleted the ekilmer/version-docker-images branch May 17, 2023 20:27
ekilmer added a commit that referenced this pull request May 17, 2023
* master:
  Only push a single image, including mono for caching
  docker: Fix working-directory when building images
  Docker images v2 (#1021)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants