-
Notifications
You must be signed in to change notification settings - Fork 12
Docker image v2 #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Docker image v2 #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubuntu and vcpkg better support using GCC for cross compilation
d8a6e27 to
2cbe78d
Compare
2cbe78d to
f788277
Compare
* master: Test Remill with LLVM 16 (#1016)
Ninja3047
requested changes
May 17, 2023
Collaborator
Ninja3047
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit
ghcr.io is now available for unauthenticated pulls
Collaborator
Author
|
Oh wait. Hmmmm |
Ninja3047
approved these changes
May 17, 2023
ekilmer
added a commit
that referenced
this pull request
May 17, 2023
* master: Only push a single image, including mono for caching docker: Fix working-directory when building images Docker images v2 (#1021)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL #1018 passesNew naming scheme appends
-v#to the image name. The tag part is not changedRemoved Docker Hub pushes. Now we use ghcr.io for both images.
Use GCC for cross-compilation on Linux because Ubuntu and vcpkg have better support for cross-compilation when using GCC