Add llvm-16 patch to not crash on invalid sourcelocs #1023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Any preferences on how we do clang patches like this? ie. gated behind a flag? |
Ninja3047
approved these changes
May 31, 2023
Collaborator
Ninja3047
left a comment
Ninja3047
left a comment
There was a problem hiding this comment.
i'm fine with including it since it's not adding new stuff and is just a bug fix
ekilmer
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang 16 added a semantic check for flexible array members that relies on grabbing sourceloc info for array types that are the last member of a union. If the sourceloc info is empty
dyn_cast<IntegerLiteral>(CTL.getSizeExpr())will crash because getSizeExpr will be null and dyn_cast asserts a nonnulll input. Another plausible fix would be to do dyn_cast_or_null here but that would result in false. Still determining the best patch/testing