Remove Docker image version from release artifact name #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker image version technically matters for the release artifacts themselves, but we already version them with cxx-common version
Ninja3047
reviewed
May 31, 2023
| - { name: 'ubuntu-v2', tag: '20.04' } | ||
| - { name: 'ubuntu-v2', tag: '22.04' } | ||
| # 'name' is Docker image name whereas 'os' is more generic | ||
| - { os: 'ubuntu', name: 'ubuntu-v2', tag: '20.04' } |
Collaborator
There was a problem hiding this comment.
is it still useful to have the name here if we're just going to use matrix.image.os?
Collaborator
Author
There was a problem hiding this comment.
We use name for the docker container that we run the steps in and also in the caches
Ninja3047
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker image version technically matters for the release artifacts themselves, but we already version them with cxx-common version.
This change reduces churn in downstream