Some stuff I seemed to have forgotten to commit #869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekilmer
requested changes
Dec 15, 2021
Collaborator
ekilmer
left a comment
ekilmer
left a comment
There was a problem hiding this comment.
If more ports (aside from LLVM) need special handling for sanitizers, then we need to make sure VCPKG doesn't add the flags for each asan triplet, like here
cxx-common/triplets/arm64-osx-asan.cmake
Line 10 in 77daa7a
ekilmer
force-pushed
the
upgrade_grpc_upb_flatbuffers
branch
from
44395a5 to
b0d208b
Compare
ekilmer
force-pushed
the
upgrade_grpc_upb_flatbuffers
branch
from
b0d208b to
608dc50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.