new grpc patch for absl sync #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekilmer
approved these changes
Dec 16, 2021
Collaborator
ekilmer
left a comment
ekilmer
left a comment
There was a problem hiding this comment.
I think this patch could be implemented differently to attach the definitions as PUBLIC to the relevant existing grpc targets instead of creating a new interface library where the consumer needs to remember to link to it.
But since this repo is for patches and only used for providing dependencies to the tools we develop, this is probably fine. It should also try to make its way into upstream at some point.
Contributor
Author
|
The consumer doesn't need to link it; I dealt with that by installing the target, and also adding it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.