Added support for rocksdb #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekilmer
reviewed
Feb 18, 2022
Collaborator
ekilmer
left a comment
ekilmer
left a comment
There was a problem hiding this comment.
This is older than what is checked in to the vcpkg repo that we use. Is there a reason for using an older version?
Contributor
Author
There is no reason of using the older version. I didn't check the default version checkout with vcpkg. We can use the same for installing the dependencies. |
kumarak
force-pushed
the
kumarak/rocksdb_support
branch
from
4b6fe4c to
d31e2e2
Compare
Contributor
Author
|
@ekilmer, I updated the PR. I don't need a specific version and can use the default version with vcpkg. |
ekilmer
approved these changes
Feb 18, 2022
ekilmer
added a commit
that referenced
this pull request
Feb 18, 2022
* master: Added support for rocksdb in the package (#898) Simplify build script (#897) Install LLVM utils tools (#893) Update to latest vcpkg commit (#892) Update to LLVM 13.0.1 (#891) Bump lukka/run-vcpkg from 10.0 to 10.1 (#889) Ian/fix memory issue in xed (#884) Add roaring to default dependencies and distribution (#877) Fix vcpkg default host triplet (#876) Build cxx-common architecture targets when building llvm via vcpkg.json (#874)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for packaging rocksdb with cxx-common.