add LLVM relocation patch #911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekilmer
reviewed
Mar 11, 2022
Contributor
Author
|
Modified the patch to provide a static option on the ELF loader to disable hard errors on relocation failures. |
artemdinaburg
requested changes
Mar 11, 2022
remove triplet change
2over12
force-pushed
the
ian/patch-relocation-checks-in-elf-loader
branch
from
658cddf to
ef636df
Compare
Contributor
Author
|
Following up on this PR, I'm using it locally and it does allow us to load binaries. |
ekilmer
reviewed
Mar 14, 2022
Contributor
|
Can we get cap'n proto in too? |
ekilmer
changed the title
This is now useful with the new build script to let users know when a new update is available
artemdinaburg
approved these changes
Mar 17, 2022
ekilmer
added a commit
that referenced
this pull request
Mar 18, 2022
* master: Prevent build script from clobbering this repo add LLVM relocation patch (#911) Add capnproto as default dependency (#915) Always add sanitizer flags when linking (#912) Build script improvements (#907) Bump actions/upload-artifact from 2.3.1 to 3 (#906) Bump actions/checkout from 2.4.0 to 3 (#905) Bump actions/setup-dotnet from 1.9.1 to 2 (#903) Bump actions/setup-dotnet from 1.9.0 to 1.9.1 (#902)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im not happy merging this as is because it skips relocations that it is unable to apply in elfs without applying them. This should probably be gated behind a feature or something