Skip to content

Fix ASAN Builds #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 26, 2022
Merged

Fix ASAN Builds #921

merged 12 commits into from
Mar 26, 2022

Conversation

@artemdinaburg
Copy link
Contributor

@artemdinaburg artemdinaburg commented Mar 24, 2022 •
edited by ekilmer
Loading

ekilmer
ekilmer reviewed Mar 24, 2022
View reviewed changes
@ekilmer
Copy link
Collaborator

ekilmer commented Mar 25, 2022

The issue here is that CMake uses the clang in the Xcode toolchain path which behaves differently than the one in /usr/bin 😕 . This means that XED isn't able to find some common language headers like string.h because there are no system includes with the Xcode toolchain clang...

Not sure exactly how to work around this. Will investigate more about what vcpkg can tell us in the portfile.cmake file

@ekilmer
Copy link
Collaborator

ekilmer commented Mar 25, 2022 •
edited
Loading

There's a fix in the latest commit of vcpkg, so we should bump to that. Done and being tested in #922

Edit: Cherry-picked to this branch

ekilmer added 5 commits March 25, 2022 15:27
@ekilmer
Bump vcpkg commit and fix XED compilation on macOS
d436fcb 
Upstream had a fix for sysroot include directory
microsoft/vcpkg@a34997a
@ekilmer
Use gcc-compatible -gfull flag
1197ed0
@ekilmer
Update vcpkg to latest commit
906fc2a
@ekilmer
Correctly pass all vcpkg flags to XED buildsystem
e04607c 
Now we build with the selected compiler instead of whatever mbuild was
picking up. We also correctly add the requested vcpkg flags, which
affects the sanitizer build(s).
@ekilmer
Merge branch 'fix-xed' into artem/asan-fix
aec4868 
* fix-xed:
  Correctly pass all vcpkg flags to XED buildsystem
  Update vcpkg to latest commit
  Fix typo in AWS ARM64 Docker builder
  Use AWS for arm64 docker images (#920)
@ekilmer ekilmer mentioned this pull request Mar 25, 2022
Merged
1 task
@ekilmer
Merge branch 'master' into artem/asan-fix
b635f17 
* master:
  Correctly pass all vcpkg flags to XED buildsystem (#925)
  Update vcpkg to latest commit (#924)
@ekilmer
Copy link
Collaborator

ekilmer commented Mar 25, 2022 •
edited
Loading

Hmmm. It seems -fno-eliminate-unused-debug-symbols isn't actually a flag on Linux clang... I'm just going to remove it in favor of plain old -g

@ekilmer ekilmer merged commit d4dbbe4 into master Mar 26, 2022
@ekilmer ekilmer deleted the artem/asan-fix branch March 26, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekilmer ekilmer ekilmer left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@artemdinaburg @ekilmer