LLVM FindZ3.cmake now attempts to use Z3's CONFIG file #934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hopefully leads to better performance and consistency when finding Z3 multiple times. vcpkg ships Z3's config cmake file, so this should always hit. This _should_ work in the general case if Z3 config file is not installed but it is not thoroughly tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully leads to better performance and consistency when finding
Z3 multiple times.
vcpkg ships Z3's config CMake file, so this should always hit.
This should work in the general case if the Z3 config file is not
installed but that case is not thoroughly tested.