Don't Bail If Optional Property Is Nullified#522
Closed
karthicks wants to merge 4 commits intolightbend:mainfrom
Closed
Don't Bail If Optional Property Is Nullified#522karthicks wants to merge 4 commits intolightbend:mainfrom
karthicks wants to merge 4 commits intolightbend:mainfrom
Conversation
|
Is there anything left to do on this? |
Author
|
@Lavoaster , No, there is nothing left to do on this. This is good to go. To reiterate, if one were to set an optional property to null, then with this change, a "false negative" exception will not be raised (see #440 for more details). -Karthick |
Author
|
Can we make this a |
|
Hi. I'm also trying to figure out a way to omit specific bean properties from bean definitions in Kotlin. Any plans to merge this PR in? Thanks! |
Author
|
Thanks for pulling this into the next release. |
Member
|
We do not intend to extend the functionality of "Typesafe Config" further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@havocp ,
This is a continuation of an earlier pull request, which got closed accidentally. I addressed the last comment you had in there here.
For details on the problem description, please refer to #440.
Regards,
Karthick