-
Notifications
You must be signed in to change notification settings - Fork 32
Add support for Scala 2.12.13 #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d2d0885 to
95810c4
Compare
95810c4 to
a02702e
Compare
|
Thank you, @SethTisue. Can we have a release with 2.12.13 support? I was validating this Scala version in Lightbend Telemetry, but it depends on genjavadoc support. Edit: Not in a rush, though. I can always cut a release locally to validate everything is fine. |
|
the release levers in this repo are pulled by @raboof |
|
I don't really want to be a bottleneck here, so it'd be good if more people could do this... but happy to take care of it again :) |
|
@raboof no good deed goes unpunished: one day you volunteer, then before you know it it's your job :-) does |
It does, but... ... but the artifacts do seem to have been updated in |
|
looks like it's trying to publish for multiple Scala versions. not sure if it would help if I saw a more complete log that included the actual commands you issued but yeah maybe it's fine if the ones that we already published for fail as expected, as long as the one we want succeeds @marcospereira let us know if there's a problem (after waiting for propagation) |
|
@raboof I think it failed because 0.16 is already there for Scala 2.13.4, so it won't override the existing release.
And https://repo1.maven.org/maven2/com/typesafe/genjavadoc/genjavadoc-plugin_2.13.4/0.16/ shows it was released Let me try and later @SethTisue can punish me too. |
|
0.16 artifacts for Scala 2.12.13 are there now. It will just take the usual time to sync to the central repo. :-) |
|
Oops, my local sonatype-staging still had the 2.13.4 artifacts. Makes sense after all ;) #261 |
I hope this is all it needs. 😅