-
Notifications
You must be signed in to change notification settings - Fork 32
Add support for Scala 2.13.5 #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,20 +46,13 @@ lazy val defaults = Seq( | |
| sonatypeProfileName := "com.typesafe", | ||
| scalaVersion := crossScalaVersions.value.last, | ||
| crossScalaVersions := { | ||
| val earliest211 = 6 | ||
| val latest211 = 12 | ||
| val latest212 = 13 | ||
| val latest213 = 4 | ||
| val skipVersions = Set("2.11.9", "2.11.10") | ||
| val scala211Versions = | ||
| (earliest211 to latest211) | ||
| .map(i => s"2.11.$i") | ||
| .filterNot(skipVersions.contains(_)) | ||
| ifJavaVersion(_ < 8) { | ||
| scala211Versions | ||
| } { | ||
| scala211Versions ++ (0 to latest212).map(i => s"2.12.$i") ++ (0 to latest213).map(i => s"2.13.$i") | ||
| } | ||
| // Remember to keep this list aligned with .travis.yml | ||
| // 2.11.6 is the first to be supported and we skip 2.11.9 and 2.11.10 | ||
| val supportedScala211Versions = Seq("2.11.6", "2.11.7", "2.11.8", "2.11.11", "2.11.12") | ||
| // Scala 2.12.[0-2] are not supported | ||
| val supportedScala212Versions = (3 to 13).map(p => s"2.12.$p") | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Scala |
||
| val supportedScala213Versions = (0 to 5).map(p => s"2.13.$p") | ||
| supportedScala211Versions ++ supportedScala212Versions ++ supportedScala213Versions | ||
| }, | ||
| scalaMajorVersion := CrossVersion.partialVersion(scalaVersion.value).get._2.toInt, | ||
| resolvers += Resolver.mavenLocal, | ||
|
|
@@ -74,10 +67,3 @@ lazy val defaults = Seq( | |
| ) | ||
|
|
||
| lazy val browse = SettingKey[Boolean]("browse", "run with -Ybrowse:uncurry") | ||
|
|
||
| def ifJavaVersion[T](predicate: Int => Boolean)(yes: => T)(no: => T): T = { | ||
| System.getProperty("java.version").split("\\.").toList match { | ||
| case "1" :: v :: _ if predicate(v.toInt) => yes | ||
| case _ => no | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we are not supporting any Java version older than 8. 🙏🏼