Convert Scala @throws annotations to Java throws clauses #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good but I'm not very deep into this codebase, second review by @rkuhn or @2m (or @bantonsson)? |
Contributor
|
In order to merge this we'll have to ask you to sign out contributor agreement, it's pretty easy: http://www.typesafe.com/contribute/cla just follow the steps on that site and confirm with yout github account (no physical paperwork needed). |
Contributor
|
LGTM |
Contributor
Author
|
I have signed the contributor agreement. |
Contributor
|
Great, thanks @stevedlawrence! |
ktoso
added a commit
that referenced
this pull request
Jun 22, 2015
Convert Scala @throws annotations to Java throws clauses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent versions of javadoc, checks are made to ensure that throws
clasues exist for any javadoc @throws tags. This patch converts Scala
@throws annotations to the Java throws clause so that these checks can
pass.