Deleting in batches #277
Merged
Deleting in batches #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| BulkWriteOperation bw = collection.initializeUnorderedBulkOperation(); | ||
|
|
||
| List<Object> _ids = docsToDelete.stream().map(d -> d._id).collect(Collectors.toList()); | ||
| bw.find(new BasicDBObject("_id", new BasicDBObject("$in", _ids))).remove(); |
Contributor
There was a problem hiding this comment.
No need for bulk ops here. collection.remove(inQuery} should do
Or, instead of an $in query, we can remove one document in each operation of the bulk operation so we can get the results correctly:
bw.find(BasicDBObject("_id",id)).remove()
I think doing bulk is better, so if any doc is removed by another process, we'd know.
| private void handleBulkWriteError(List<BulkWriteError> errors, List<DocInfo> docs) { | ||
| for (BulkWriteError e : errors) { | ||
| DocInfo doc = docs.get(e.getIndex()); | ||
| // TODO: what error should we use here? |
Contributor
Author
There was a problem hiding this comment.
Please comment on this, I'm not sure which error code to use here. Maybe we need a new one?
Contributor
There was a problem hiding this comment.
remove() doesn't throw any meaningful exceptions, a generic DELETE exception should do.
Contributor
Author
|
After adding ERR_DELETE_ERROR, #106 should be also covered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#268
Work in progress. Feedback welcome, but do not merge yet.