Fix #349: JS generation should check the validity of all levels in a …

[bserdar]

…field name

[paterczm]

What is this empty loop for?

[bserdar]

Leftover from refactoring. Removed.

…

On Mon, Mar 6, 2017 at 10:32 AM, Marek ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In mongo/src/main/java/com/redhat/lightblue/mongo/crud/js/IfStatement.java <#350 (comment)> : > @@ -28,11 +28,27 @@ public IfStatement(Expression test,Statement...s) { } public static IfStatement ifDefined(Name var,Statement...s) { - return new IfStatement(new SimpleExpression("typeof this.%s != 'undefined'", var),s); + StringBuffer b=new StringBuffer(64); + for(int i=0;i<var.length();i++) { + } What is this empty loop for? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#350 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADgDDRF2Zsmsk90uXWsqNKNMl-k-Ewzsks5rjENHgaJpZM4MUbrt> .

[dcrissman]

Is it worth touching this class just for spacing changes?

[bserdar]

The test compares with spaces, so I had to fix the string to match the generated string.

…

On Mon, Mar 6, 2017 at 11:36 AM, Dennis Crissman ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In mongo/src/test/java/com/redhat/lightblue/mongo/crud/TranslatorTest.java <#350 (comment)> : > @@ -326,11 +326,11 @@ public void translateNullReference() throws Exception { @test public void translateJS() throws Exception { DBObject obj = expressionTranslator.translate(md, query("{'field':'field7.*.elemf1','op':'=','rfield':'field7.*.elemf2'}")); - Assert.assertEquals("function() {var r0=false;{if(typeof this.field7 != 'undefined'){for(var ri1=0;ri1<this.field7.length;ri1++){if(typeof this.field7 != 'undefined'){for(var ri2=0;ri2<this.field7.length;ri2++){r0=field7[ri1].elemf1 == field7[ri2].elemf2;if(r0){break;}}}if(r0){break;}}}}return r0;}", + Assert.assertEquals("function() {var r0=false;{if(typeof this.field7!='undefined'){for(var ri1=0;ri1<this.field7.length;ri1++){if(typeof this.field7!='undefined'){for(var ri2=0;ri2<this.field7.length;ri2++){r0=field7[ri1].elemf1 == field7[ri2].elemf2;if(r0){break;}}}if(r0){break;}}}}return r0;}", Is it worth touching this class just for spacing changes? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#350 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADgDDaDPUIYBdYwJ609Cu1jZZAntXyjEks5rjFIegaJpZM4MUbrt> .