Skip to content

Conversation

@jekh
Copy link
Collaborator

jekh commented Mar 7, 2016

The host and port shouldn't be duplicated in HAR filter when the URI parsing fails. The best place to fix that is in HarCaptureFilter, where the duplication is occurring.

The curly braces {} shouldn't appear in a URL unescaped. RFC 1738 states:

Other characters are unsafe because
   gateways and other transport agents are known to sometimes modify
   such characters. These characters are "{", "}", "|", "\", "^", "~",
   "[", "]", and "`".
   All unsafe characters must always be encoded within a URL.

So, I'm not keen on changing our URI parsing from a standards-compliant parser to a non-standards-compliant parser. I do recognize that as a proxy BMP has to be pretty lenient, but I'd rather handle this by fixing the duplication issue in HarCaptureFilter when parsing an invalid URL (which the example URL certainly is).

@jekh
Copy link
Collaborator

jekh commented Mar 13, 2016

This should be fixed in master now. Let me know if you still have issues with it.

@jekh jekh closed this Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants