Skip to content

Fix missing mimeType in HAR #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2016
Merged

Fix missing mimeType in HAR #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion browsermob-core-littleproxy/src/main/java/net/lightbody/bmp/filters/HarCaptureFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,10 @@ protected void captureResponse(HttpResponse httpResponse) {

protected void captureResponseMimeType(HttpResponse httpResponse) {
String contentType = HttpHeaders.getHeader(httpResponse, HttpHeaders.Names.CONTENT_TYPE);
harEntry.getResponse().getContent().setMimeType(contentType);
// don't set the mimeType to null, since mimeType is a required field
if (contentType != null) {
harEntry.getResponse().getContent().setMimeType(contentType);
}
}

protected void captureResponseCookies(HttpResponse httpResponse) {
Expand Down
4 changes: 4 additions & 0 deletions browsermob-core/src/main/java/net/lightbody/bmp/core/har/HarContent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@
public class HarContent {
private volatile long size;
private volatile Long compression;

// mimeType is required; though it shouldn't be set to null, if it is, it still needs to be included to comply with the HAR spec
@JsonInclude(JsonInclude.Include.ALWAYS)
private volatile String mimeType = "";

private volatile String text;
private volatile String encoding;
private volatile String comment = "";
Expand Down