Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Your preview environment pr-17602 has been deployed. Preview environment endpoints are available at: |
|
Preview environment logs can be accessed at: https://console.cloud.google.com/logs/query;query=resource.labels.namespace_name%3D%22pr-17602%22;duration=PT30M?project=lightdash-previews |
|
You can ssh into the preview environment by running: |
pimmey
approved these changes
Oct 23, 2025
Contributor
Author
Merge activity
|
notgiorgi
deleted the
fix_update_table_calculation_test_to_use_payment_method_instead_of_total_revenue
branch
lightdash-bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
Collaborator
|
🎉 This PR is included in version 0.2104.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Updated the SQL query in the table calculation test to order by
payments_payment_methodin ascending order instead of ordering bypayments_total_revenuein descending order. This change ensures the running total calculation is performed based on payment method rather than revenue amount.