feat: detect login page redirects in screenshot service#19505
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Your preview environment pr-19505 has been deployed. Preview environment endpoints are available at: |
Preview Environment🌐 URL: https://lightdash-preview-pr-19505.lightdash.okteto.dev 📋 Logs: View in GCP Console 🔧 SSH: |
pimmey
changed the base branch from
error-boundry-unfurl-service-throw
to
graphite-base/19505
pimmey
force-pushed
the
graphite-base/19505
branch
from
a37b971 to
7c196e4
Compare
pimmey
force-pushed
the
detect-redirect-to-login-in-unfurl-service
branch
from
df9119e to
e21cbb3
Compare
pimmey
force-pushed
the
detect-redirect-to-login-in-unfurl-service
branch
from
e21cbb3 to
ce11c03
Compare
ZeRego
approved these changes
Jan 19, 2026
Contributor
Author
Collaborator
|
🎉 This PR is included in version 0.2352.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #19506
Description:
Improved error detection in UnfurlService by adding login page detection to catch authentication failures during screenshot generation.
The PR refactors the error detection logic in the screenshot service to:
This enhancement helps diagnose issues where users are unexpectedly redirected to the login page instead of seeing their requested content in screenshots.