Conversation
Contributor
Author
|
/review |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a redundant second Pydantic validation/conversion step in the training command flow so the original config model type (e.g., ObjectDetectionConfig) is preserved, relying on the existing validation already performed in _train_task.
Changes:
- Removed re-validation/re-construction of
configintoTrainTaskConfiginside_train_task_from_config. - Ensures the config instance type remains the specific
config_clsproduced by_train_taskvalidation.
yutong-xiang-97
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has changed and why?
Removes an extra config validation step which converted all configs to
TrainTaskConfig. The extra validation is no longer necessary as we already validate the config in_train_task(5 lines above the change). The extra validation also resulted in all config classes getting converted toTrainTaskConfiginstances instead of keeping their original class, e.g.ObjectDetectionConfig. This didn't result in any bugs because we never rely on the instance type of the config but avoiding the conversion is clearly the better solution and prevents future bugs.How has it been tested?
Did you update CHANGELOG.md?
Did you update the documentation?