Raise error if best_metrics.metrics.watch_metric != last_metrics.watch_metric#659
Merged
yutong-xiang-97 merged 4 commits intomainfrom Mar 23, 2026
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens correctness in best-metric tracking by failing fast when the “best so far” metrics and the “latest” metrics disagree on which watch metric is being tracked, preventing silent mis-selection of best checkpoints.
Changes:
- Change
get_best_metricsto raise aRuntimeErrorwhenbest.watch_metric != last.watch_metricinstead of silently returning the previous best. - Add a unit test that asserts the new error is raised on mismatched watch metrics.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/lightly_train/_commands/train_task_helpers.py |
Raises an explicit error when best vs. last aggregated metrics use different watch_metric. |
tests/_commands/test_train_task_helpers.py |
Adds a pytest unit test covering the new mismatch error behavior. |
Contributor
Author
|
/review |
…etricswatch_metric
guarin
approved these changes
Mar 23, 2026
…etricswatch_metric
yutong-xiang-97
deleted the
yutong-trn-1842-raise-error-if-best_metricsmetricswatch_metric
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has changed and why?
As the title suggests.
How has it been tested?
An additional unit test.
Did you update CHANGELOG.md?
Did you update the documentation?