Log Epochs in Console and Loggers#680
Merged
yutong-xiang-97 merged 2 commits intomainfrom Apr 2, 2026
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
Author
|
/review |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds 1-based epoch information to both console step logs and structured logger outputs during training/validation, derived from the training step count, train dataloader length, and gradient accumulation.
Changes:
- Compute a
current_epochduring the training loop and pass it into console logging for train/val steps. - Add
get_training_epoch(...)helper to derive a 1-based epoch from step and batch counts. - Include
epochas a logged scalar inlog_fabric(...)and document the addition inCHANGELOG.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lightly_train/_commands/train_task.py | Computes current_epoch each step and plumbs it into console + fabric logging for train/val. |
| src/lightly_train/_commands/train_task_helpers.py | Adds epoch derivation helper and extends log_step / log_fabric to emit epoch. |
| CHANGELOG.md | Notes the new 1-based epoch logging behavior. |
simonschoelly
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has changed and why?
As the title suggests.
How has it been tested?
Manually:
Did you update CHANGELOG.md?
Did you update the documentation?