Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e049c9c590
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Adds support for Meta’s EUPE checkpoints in the DINOv3 model package and ensures EUPE backbones can be used with the DINOv3 LTDETR object detection task.
Changes:
- Register new
*-eupeDINOv3 backbone names and point them at EUPE checkpoint URLs. - Make LTDETR config selection tolerant to
-eupesuffixes on backbone names. - Strip EUPE-specific projector weights from loaded checkpoints to keep strict state-dict loading working.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/lightly_train/_task_models/dinov3_ltdetr_object_detection/task_model.py |
Strips -eupe from backbone names when selecting the LTDETR config. |
src/lightly_train/_models/dinov3/dinov3_src/hub/backbones.py |
Filters EUPE-only state-dict keys before strict loading for ViT and ConvNeXt backbones. |
src/lightly_train/_models/dinov3/dinov3_package.py |
Adds EUPE model-name entries mapping to existing backbone builders + EUPE checkpoint URLs. |
|
/review |
liopeer
left a comment
There was a problem hiding this comment.
LGTM! I will create a follow-up to add support for other downstream tasks and to document it.
All downstream tasks should already be supported. LTDETR just needed some extra logic |
What has changed and why?
Adds support for the new EUPE models from Meta.
Usage is very simple. Instead of
model="dinov3/vits16"for pretraining ormodel="dinov3/vits16-ltdetr"for fine-tuning you can now usemodel="dinov3/vits16-eupe"for pretraining with EUPE ormodel="dinov3/vits16-eupe-ltdetr"for fine-tuning.I'll add docs/changelog in a follow up once #691 is merged.
Distillation
Fine-tuning
How has it been tested?
Did you update CHANGELOG.md?
Did you update the documentation?