Fix epoch calculation#698
Merged
yutong-xiang-97 merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
Author
|
/review |
guarin
approved these changes
Apr 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts training epoch logging to reflect the number of completed epochs (0-based), aligning console/logger output with the intended epoch semantics.
Changes:
- Update
get_training_epoch()to compute completed epochs via integer division. - Update the changelog entry describing epoch logging semantics.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/lightly_train/_commands/train_task_helpers.py |
Changes epoch calculation used for logging from 1-based “current epoch” to 0-based “completed epochs”. |
CHANGELOG.md |
Updates unreleased entry to describe the new epoch logging semantics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has changed and why?
Update the epoch calculation to log the completed number of epochs, i.e. starting from 0.
How has it been tested?
Did you update CHANGELOG.md?
Did you update the documentation?