Skip to content

Conversation

@suresh-gangumalla
Copy link
Collaborator

Updated create-app to support .blits file extension project for both Javascript and Typescript

Updated create-app to support .blits file extension project
for both Javascript and Typescript

Signed-off-by: Suresh Kumar Gangumalla <sureshkumar.gangumalla@invecas.com>
Copy link
Collaborator

@michielvandergeest michielvandergeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @suresh-gangumalla! This looks good already! But I notice there is some duplication going on now between the .blits version and the plain js / ts versions

I think the default folder was created as a form to add more than one template (in the future). So ideally we'd nest the blits file format and regular format inside those folders and reuse anything that's common per template

So maybe it makes more sense to reorganize the folder to have the template (default in this case) to be at the top level and then inside it make the variations of ts/js and blits/plain? And then the files like index.html and .env.example can possibly be shared?

Also, since we're building this agains the v2 branch, we should probably use the v2 preferred syntax for props

Signed-off-by: Suresh Kumar Gangumalla <sureshkumar.gangumalla@invecas.com>
Signed-off-by: Suresh Kumar Gangumalla <sureshkumar.gangumalla@invecas.com>
Signed-off-by: Suresh Kumar Gangumalla <sureshkumar.gangumalla@invecas.com>
Copy link
Collaborator

@michielvandergeest michielvandergeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michielvandergeest michielvandergeest merged commit a152629 into lightning-js:v2/update Oct 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants