Skip to content

Release 2.4.1#683

Merged
michielvandergeest merged 5 commits into
masterfrom
dev
Jun 2, 2026
Merged

Release 2.4.1#683
michielvandergeest merged 5 commits into
masterfrom
dev

Conversation

@michielvandergeest
Copy link
Copy Markdown
Collaborator

  • Fixed router issue with initial redirect

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Linting errors found

These linting errors must be fixed before this PR can be merged:

src/router/router.test.js
  Line 823:3: 'registerRouterView' is not defined. (no-undef)
  Line 847:5: 'unregisterRouterView' is not defined. (no-undef)
  Line 918:3: 'registerRouterView' is not defined. (no-undef)
  Line 919:3: 'registerRouterView' is not defined. (no-undef)
  Line 946:5: 'unregisterRouterView' is not defined. (no-undef)
  Line 947:5: 'unregisterRouterView' is not defined. (no-undef)

Run npm run lint:fix to automatically fix some of these issues.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Test Results: ❌ FAILED

Run at: 2026-06-02T12:13:49.513Z

Summary:
passed: 1232 failed: 5 of 1237 tests

Failed tests:

not ok 1181 ReferenceError: registerRouterView is not defined
  ---
    operator: error
    stack: |-
      ReferenceError: registerRouterView is not defined
          at Test.<anonymous> (file:///home/runner/work/blits/blits/src/router/router.test.js:823:3)
          at Test.run (/home/runner/work/blits/blits/node_modules/tape/lib/test.js:126:28)
          at Immediate.next (/home/runner/work/blits/blits/node_modules/tape/lib/results.js:158:7)
          at process.processImmediate (node:internal/timers:483:21)
  ...

not ok 1182 ReferenceError: registerRouterView is not defined
  ---
    operator: error
    stack: |-
      ReferenceError: registerRouterView is not defined
          at Test.<anonymous> (file:///home/runner/work/blits/blits/src/router/router.test.js:918:3)
          at Test.run (/home/runner/work/blits/blits/node_modules/tape/lib/test.js:126:28)
          at Immediate.next (/home/runner/work/blits/blits/node_modules/tape/lib/results.js:158:7)
          at process.processImmediate (node:internal/timers:483:21)
  ...

not ok 1193 Redirect should update the named RouterView hash segment
  ---
    operator: equal
    expected: |-
      '/named-redirected'
    actual: |-
      '/'
    at: Test.<anonymous> (file:///home/runner/work/blits/blits/src/router/router.test.js:1184:10)
    stack: |-
      Error: Redirect should update the named RouterView hash segment
          at Test.assert [as _assert] (/home/runner/work/blits/blits/node_modules/tape/lib/test.js:492:48)
          at Test.strictEqual (/home/runner/work/blits/blits/node_modules/tape/lib/test.js:670:7)
          at Test.<anonymous> (file:///home/runner/work/blits/blits/src/router/router.test.js:1184:10)
          at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  ...

not ok 1194 Redirect should not replace the main route
  ---
    operator: equal
    expected: |-
      '/'
    actual: |-
      '/named-original'
    at: Test.<anonymous> (file:///home/runner/work/blits/blits/src/router/router.test.js:1189:10)
    stack: |-
      Error: Redirect should not replace the main route
          at Test.assert [as _assert] (/home/runner/work/blits/blits/node_modules/tape/lib/test.js:492:48)
          at Test.strictEqual (/home/runner/work/blits/blits/node_modules/tape/lib/test.js:670:7)
          at Test.<anonymous> (file:///home/runner/work/blits/blits/src/router/router.test.js:1189:10)
          at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  ...

not ok 1195 TypeError: Cannot read properties of undefined (reading 'path')
  ---
    operator: error
    stack: |-
      TypeError: Cannot read properties of undefined (reading 'path')
          at Test.<anonymous> (file:///home/runner/work/blits/blits/src/router/router.test.js:1192:34)
          at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  ...

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Test Results: ✅ PASSED

Run at: 2026-06-02T12:22:17.969Z

Summary:
passed: 1247 failed: 0 of 1247 tests

@michielvandergeest michielvandergeest merged commit 22b20ce into master Jun 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant