memize shaders and timing functions #131
Conversation
| ); | ||
|
|
||
| // If all the colors are the same just sent them all to the same value | ||
| if ( |
There was a problem hiding this comment.
A bit surprised this would have much of an impact as these colors, unless they are changed, should only be calculated once for the node and never again during the life cycle of the node. Is it like an on-going FPS drop or just like an initial page load drop?
There was a problem hiding this comment.
99% of nodes are a single color - then passed to the render its split into the four props - and then the alpha color is calculated 4 times per node.
Also these are recalculated a lot as alpha fade in out is one of the biggest animations - and I assume that gets recalculated with a new alpha value
| 'colorTr', | ||
| 'colorBl', | ||
| 'colorBr', | ||
| ]; |
There was a problem hiding this comment.
The biggest culprit here was probably reinitializing this array rather than storing it as a const at the top of the file.
frank-weindel
left a comment
frank-weindel
left a comment
There was a problem hiding this comment.
With all checks passing this LGTM
Added Memize library to add a layer of caching for timing functions and Dynamic shader.
Optimized shader to return same default object which allows memize to use the object as a key efficiently. Thus most effects reuse the same props results.