DynamicShader: Fix mixing gradient colors with maskcolor #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frank-weindel
approved these changes
Oct 5, 2023
| width: 250, | ||
| height: 500, | ||
| color: 0x00000000, | ||
| color: 0xff0000ff, |
Contributor
There was a problem hiding this comment.
This PR totally LGTM! When you get some time could you try to work in the new row pagination system I created for clipping test? It will let you display many more examples (since it paginates) and let you describe what you're testing (as row headers).
frank-weindel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chris found an issue with gradients that contained alpha lower than 1. This PR resolves that issue.