-
Notifications
You must be signed in to change notification settings - Fork 30
fix: font face descriptors in chrome 38 #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: font face descriptors in chrome 38 #490
Conversation
|
I recommend removing the object.fromEntries as that usually doesnt get compiled correctly on older devices |
|
@chiefcll TBH a lot of features are missing on older devices, like |
Although not wrong, if the idea is to make stuff work on Chrome v38 you can easily achieve the same with functionality that we know is available on chrome v38. Avoiding another place to polyfill and providing consistent behaviour, likely get some (albeit super minor) performance increases on the way. I'm with Chris here, you can easily achieve the same with e.g. a |
wouterlucas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace Object.fromEntries with a for loop or similar, to align with targeted chrome v38 functionality.
wouterlucas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
In chrome 38 if some attribute is undefined the font is not loaded