Fix clipping when node is scaled #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clipping area is now scaled appropriately according to the `scale` properties.
frank-weindel
requested review from
chiefcll,
erikhaandrikman,
jfboeve,
michielvandergeest and
wouterlucas
chiefcll
approved these changes
Oct 25, 2023
Contributor
|
What's the rationale behind disabling clipping when rotating a node? |
Contributor
Author
Same rationale that Lightning 2 employed. The WebGL scissor operation only works with a axis aligned rectangles. Clipping for rotated rectangles will be achievable with RTT. |
erikhaandrikman
approved these changes
Oct 26, 2023
Contributor
ahh! makes sense, thanks for explaining 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clipping area is now scaled appropriately according to the
scaleproperties.Clipping is also now disabled when a clipping node is rotated (Lightning 2 behavior).
Fixes #54