Skip to content

Fix failed event on retry exhausted #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2025
Merged

Fix failed event on retry exhausted #651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89dff36
fix: emit texture failure event only after exhausting retry attempts
wouterlucas Oct 3, 2025
d1b0d64
fix: subtexture failed state
jfboeve Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/core/CoreNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,10 +918,16 @@ export class CoreNode extends EventEmitter {
this.notifyParentRTTOfUpdate();
}

this.emit('failed', {
type: 'texture',
error,
} satisfies NodeTextureFailedPayload);
// only emit failed outward if we've exhausted all retry attempts
if (
this.texture !== null &&
this.texture.retryCount > this.texture.maxRetryCount
) {
this.emit('failed', {
type: 'texture',
error,
} satisfies NodeTextureFailedPayload);
}
};

private onTextureFreed: TextureFreedEventHandler = () => {
Expand Down
2 changes: 2 additions & 0 deletions src/core/textures/SubTexture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,8 @@ export class SubTexture extends Texture {
};

private onParentTxFailed: TextureFailedEventHandler = (target, error) => {
//decrement with 1 because in the failed state it will do +1 again.
this.retryCount = this.parentTexture.retryCount - 1;
this.forwardParentTxState('failed', error);
};

Expand Down