Skip to content

update dynamically when text content changes #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
Merged

update dynamically when text content changes #667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/main-api/Inspector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,16 @@ const stylePropertyMap: {
},
width: (w) => {
if (w === 0) {
return null;
// Set to 1px instead of 0px so visibility checks (e.g. Playwright) keep treating the node as visible
return { prop: 'width', value: '1px' };
}

return { prop: 'width', value: `${w}px` };
},
height: (h) => {
if (h === 0) {
return null;
// Set to 1px instead of 0px so visibility checks (e.g. Playwright) keep treating the node as visible
return { prop: 'height', value: '1px' };
}

return { prop: 'height', value: `${h}px` };
Expand Down Expand Up @@ -179,6 +181,7 @@ const knownProperties = new Set<string>([
'src',
'parent',
'data',
'text',
'texture',
]);

Expand Down Expand Up @@ -575,9 +578,10 @@ export class Inspector {
if (property === 'text') {
div.innerHTML = String(value);

// hide text because we can't render SDF fonts
// it would look weird and obstruct the WebGL rendering
div.style.visibility = 'hidden';
// Keep DOM text invisible without breaking visibility checks by using color:transparent instead of opacity:0
div.style.color = 'transparent';
div.style.pointerEvents = 'none';
div.style.userSelect = 'none';
return;
}

Expand Down