-
Notifications
You must be signed in to change notification settings - Fork 32
fix reuse render op #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix reuse render op #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1e0c28 to
b6a981d
Compare
Collaborator
|
|
Contributor
Author
|
This doesn't depend on #693 - They are separate PRs. Currently the renderer never reuses a RenderOp - on my demo I'm saving ~20% in draw calls. |
Collaborator
|
~20% O.o, that is nice.. let's clean the check up a bit: if (
params.parentHasRenderTexture === true &&
this.curRenderOp.framebufferDimensions !== null &&
params.framebufferDimensions !== null
) {
if(
this.curRenderOp.framebufferDimensions.w !== params.framebufferDimensions.w ||
this.curRenderOp.framebufferDimensions.h !== params.framebufferDimensions.h
) {
return false;
}
}this decreases the amount if !== null checks |
Contributor
Author
|
done |
jfboeve
reviewed
Jan 14, 2026
jfboeve
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parentHasRenderTexture is initialized as false, so this always returns false.