Improve inspector#795
Merged
jfboeve merged 4 commits intoMay 19, 2026
Merged
Conversation
guilhermesimoes
commented
May 18, 2026
5 tasks
chiefcll
added a commit
to solid-tv/solid
that referenced
this pull request
May 18, 2026
- Fix unparenting bug in DOM renderer: setting `parent = null` now removes the div from its previous parent (mirrors lightning-js/renderer#795), and `destroy()` is safe if the node was unparented first. - Sync `node.states` to `div.dataset.states` so focus/active states are visible in devtools and styleable via attribute selectors. - Set `componentName` for `<Dynamic component="..." />` so runtime-resolved intrinsics show up in the inspector with the same field the jsx-locator babel plugin uses. - Add Alt+click-to-log inspector (gated by `isDev` + `Config.debug`) that walks the ElementNode tree by hit-position to find the deepest visible child, logs its key state, and pins it to `window.$el`. Lives in a new `core/clickInspector.ts` with a small `initClickInspector()` entry point. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
jfboeve
requested changes
May 19, 2026
jfboeve
approved these changes
May 19, 2026
Collaborator
|
Looks good! Thanks for contributing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each commit improves its own thing, so I recommend reviewing commit by commit.
parenthandling. This includes:divs of childs created without a parent, and assigned a parent afterwards.divs of childs after they're removed from their parent.CoreNode).CoreNode).