Pin-back home for MSRV
#679
Conversation
Unfortunately, `home` bumped their MSRV to rustc 1.88 with their 0.5.12 patch release. Here, we pin it back to allow our CI to succeed under MSRV 1.85.
|
👋 Thanks for assigning @joostjager as a reviewer! |
.github/workflows/rust.yml
Outdated
| - name: Pin packages to allow for MSRV | ||
| if: matrix.msrv | ||
| run: | | ||
| cargo update -p home --precise "0.5.11" --verbose # home v0.5.12 requires rustc 1.88 or newer |
There was a problem hiding this comment.
Isn't it a problem that (security?) patches are no longer coming in now?
There was a problem hiding this comment.
Isn't it a problem that (security?) patches are no longer coming in now?
No, a) this is a test-only dependency b) it would only be required for users building on MSRV c) home should be rather trivial in the first place.
However, we now opened and landed a PR upstream on the electrsd crate (RCasatta/electrsd#114) that just removes the respective dependency entirely. Thankfully it was pushed out in a timely patch release, so we won't need the fix here after all. Pushed a revert commit to verify CI passes this step again, will close afterwards.
This reverts commit 3b9c79f.
|
Closing as no longer necessary. |
3 participants
Unfortunately,
homebumped their MSRV to rustc 1.88 with their 0.5.12 patch release. Here, we pin it back to allow our CI to succeed under MSRV 1.85.