-
Notifications
You must be signed in to change notification settings - Fork 113
Add draft changelog for LDK Node v0.7.0 #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Thanks for assigning @joostjager as a reviewer! |
5e28e82 to
c75f2d9
Compare
|
I've extract the list of merged PRs that aren't mentioned in release notes, but haven't look at it yet. #462 #542 #569 #571 #573 #577 #582 #584 #589 #590 #593 #598 #599 #601 #604 #612 #617 #623 #631 #632 #634 #635 #636 #639 #641 #643 #648 #651 #652 #655 #657 #659 #662 #663 #664 #665 #669 #670 #680 #682 #683 #688 #690 #691 #694 #695 #697 #703 #704 #707 |
joostjager
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small remarks
CHANGELOG.md
Outdated
| - Liquidity service data is now persisted across restarts. (#650) | ||
| - The bLIP-52/LSPS2 service now suports the 'client-trusts-LSP' model. (#687) | ||
| - The manual-claiming flow is now also supported for JIT invoices. (#608) | ||
| - Any key-value stores providded to `Builder::build_with_store` are now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style comment: there is a lot of use of the word 'now', which is redundant in release notes?
joostjager
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not finished checking what I wanted to check, but for a draft, it can land.
c75f2d9 to
fe14855
Compare
Went through the list and but there wasn't anything I hadn't looked at. I made slight additions now though: > git diff-tree -U2 c75f2d94 fe14855a
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 565062e7..d03401d8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,5 +5,5 @@ This seventh minor release introduces numerous new features, bug fixes, and API
- Experimental support for channel splicing has been added. (#677)
- **Note**: Splicing-related transactions might currently still get misclassified in the payment store.
-- Support for serving and paying static invoices for Async Payments has been added. (#621)
+- Support for serving and paying static invoices for Async Payments has been added. (#621, #632)
- Sourcing chain data via Bitcoin Core's REST interface is now supported. (#526)
- A new `Builder::set_chain_source_esplora_with_headers` method has been added
@@ -23,5 +23,5 @@ This seventh minor release introduces numerous new features, bug fixes, and API
## Bug Fixes and Improvements
-- Robustness of the shutdown procedure has been improved, minimizing risk of blocking during `Node::stop`. (#592, #619, #622)
+- Robustness of the shutdown procedure has been improved, minimizing risk of blocking during `Node::stop`. (#592, #612, #619, #622)
- The VSS storage backend now supports 'lazy' deletes, allowing it to avoid unnecessary remote calls for certain operations. (#689)
- The encryption and obfuscation scheme used when storing data against a VSS backend has been improved. (#627)
@@ -31,4 +31,6 @@ This seventh minor release introduces numerous new features, bug fixes, and API
current tip in `Builder::build`, avoiding re-validating the chain from
genesis on first startup. (#706)
+- A bug that could result in the node hanging on shutdown when sourcing chain data from a Bitcoin Core backend has been fixed. (#682)
+- Unnecessary fee estimation calls to Bitcoin Core RPC are now avoided. (#631)
- The node now persists differential updates instead of re-persisting full channel monitor, reducing IO load. (#661)
- The previously rather restrictive `MaximumFeeEstimate` was relaxed. (#629)Going ahead and landing this for now, as we can still make further adjustments for the actual release. |
We add a draft changelog prior to branching off
release/0.7and pushing out today's v0.7.0-rc.1 release candidate.