Skip to content

Conversation

@tnull
Copy link
Collaborator

@tnull tnull commented Nov 19, 2025

We add a draft changelog prior to branching off release/0.7 and pushing out today's v0.7.0-rc.1 release candidate.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Nov 19, 2025

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnull tnull requested a review from joostjager November 19, 2025 10:25
@tnull tnull force-pushed the 2025-11-cut-0.7.0-rc.1 branch 4 times, most recently from 5e28e82 to c75f2d9 Compare November 19, 2025 10:44
@joostjager
Copy link
Contributor

joostjager commented Nov 19, 2025

I've extract the list of merged PRs that aren't mentioned in release notes, but haven't look at it yet.

#462 #542 #569 #571 #573 #577 #582 #584 #589 #590 #593 #598 #599 #601 #604 #612 #617 #623 #631 #632 #634 #635 #636 #639 #641 #643 #648 #651 #652 #655 #657 #659 #662 #663 #664 #665 #669 #670 #680 #682 #683 #688 #690 #691 #694 #695 #697 #703 #704 #707

Copy link
Contributor

@joostjager joostjager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small remarks

CHANGELOG.md Outdated
- Liquidity service data is now persisted across restarts. (#650)
- The bLIP-52/LSPS2 service now suports the 'client-trusts-LSP' model. (#687)
- The manual-claiming flow is now also supported for JIT invoices. (#608)
- Any key-value stores providded to `Builder::build_with_store` are now
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style comment: there is a lot of use of the word 'now', which is redundant in release notes?

joostjager
joostjager previously approved these changes Nov 19, 2025
Copy link
Contributor

@joostjager joostjager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not finished checking what I wanted to check, but for a draft, it can land.

@tnull
Copy link
Collaborator Author

tnull commented Nov 19, 2025

I've extract the list of merged PRs that aren't mentioned in release notes, but haven't look at it yet.

#462 #542 #569 #571 #573 #577 #582 #584 #589 #590 #593 #598 #599 #601 #604 #612 #617 #623 #631 #632 #634 #635 #636 #639 #641 #643 #648 #651 #652 #655 #657 #659 #662 #663 #664 #665 #669 #670 #680 #682 #683 #688 #690 #691 #694 #695 #697 #703 #704 #707

Went through the list and but there wasn't anything I hadn't looked at. I made slight additions now though:

> git diff-tree -U2 c75f2d94 fe14855a
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 565062e7..d03401d8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,5 +5,5 @@ This seventh minor release introduces numerous new features, bug fixes, and API
 - Experimental support for channel splicing has been added. (#677)
     - **Note**: Splicing-related transactions might currently still get misclassified in the payment store.
-- Support for serving and paying static invoices for Async Payments has been added. (#621)
+- Support for serving and paying static invoices for Async Payments has been added. (#621, #632)
 - Sourcing chain data via Bitcoin Core's REST interface is now supported. (#526)
 - A new `Builder::set_chain_source_esplora_with_headers` method has been added
@@ -23,5 +23,5 @@ This seventh minor release introduces numerous new features, bug fixes, and API

 ## Bug Fixes and Improvements
-- Robustness of the shutdown procedure has been improved, minimizing risk of blocking during `Node::stop`. (#592, #619, #622)
+- Robustness of the shutdown procedure has been improved, minimizing risk of blocking during `Node::stop`. (#592, #612, #619, #622)
 - The VSS storage backend now supports 'lazy' deletes, allowing it to avoid unnecessary remote calls for certain operations. (#689)
 - The encryption and obfuscation scheme used when storing data against a VSS backend has been improved. (#627)
@@ -31,4 +31,6 @@ This seventh minor release introduces numerous new features, bug fixes, and API
   current tip in `Builder::build`, avoiding re-validating the chain from
   genesis on first startup. (#706)
+- A bug that could result in the node hanging on shutdown when sourcing chain data from a Bitcoin Core backend has been fixed. (#682)
+- Unnecessary fee estimation calls to Bitcoin Core RPC are now avoided. (#631)
 - The node now persists differential updates instead of re-persisting full channel monitor, reducing IO load. (#661)
 - The previously rather restrictive `MaximumFeeEstimate` was relaxed. (#629)

Going ahead and landing this for now, as we can still make further adjustments for the actual release.

@tnull tnull merged commit 3ed1d13 into lightningdevkit:main Nov 19, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants