Skip to content

Misc async API fixes #4134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2025
Merged

Misc async API fixes #4134

merged 2 commits into from
Sep 30, 2025

Conversation

TheBlueMatt
Copy link
Collaborator

No description provided.

@TheBlueMatt
Give the get_change_destination_script future access to self
b81fedc 
Its generally useful for trait methods to be able to access `self`,
sadly our definition of `get_change_destination_script` was screwed
up and couldn't. Luckily its an easy fix as none of the callsites
care about the extra `self` lifetime.
@TheBlueMatt TheBlueMatt added this to the 0.2 milestone Sep 28, 2025
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Sep 28, 2025 •
edited
Loading

I've assigned @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov Codecov
Copy link

codecov bot commented Sep 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.64%. Comparing base (19a9dbd) to head (16e4ece).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4134      +/-   ##
==========================================
+ Coverage   88.63%   88.64%   +0.01%     
==========================================
  Files         180      180              
  Lines      134878   134878              
  Branches   134878   134878              
==========================================
+ Hits       119543   119562      +19     
+ Misses      12567    12556      -11     
+ Partials     2768     2760       -8
Flag Coverage Δ
fuzzing 21.76% <0.00%> (ø)
tests 88.48% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheBlueMatt
Make util::async_poll public
16e4ece 
We have several interfaces that rely on types from `async_poll`, so
it clearly needs to be public.
@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

tnull
tnull reviewed Sep 30, 2025
View reviewed changes
Copy link
Contributor

@tnull tnull left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we export it from lightning anyways, should we drop the async_poll.rs symlink from lightning-liquidity?

@TheBlueMatt
Copy link
Collaborator Author

Hmmmmm, right, but we just use dummy_waker in lightning-liquidity, which isn't currently pub. But its not like it matters, we could also make that pub, do you care?

tnull
tnull approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@tnull tnull left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. Going ahead landing this. Also confirmed this works on LDK Node.

@tnull tnull merged commit 4ae8b3a into lightningdevkit:main Sep 30, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnull tnull tnull approved these changes

@valentinewallace valentinewallace valentinewallace approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.2

Development

Successfully merging this pull request may close these issues.

4 participants

@TheBlueMatt @ldk-reviews-bot @tnull @valentinewallace