Pin rustfmt to 1.63 #4164
Closed
Pin rustfmt to 1.63 #4164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure that cargo fmt effects remain equal to what the rustfmt CI job expects.
|
👋 Hi! I see this is a draft PR. |
tnull
reviewed
Oct 17, 2025
There was a problem hiding this comment.
Generally makes sense, but seems the change doesn't just apply to rustfmt (FWIW, in that light I'll need to double-check the LDK Node change again, too).
Also, if we make this work we should probably update our docs here https://github.com/lightningdevkit/rust-lightning/blob/main/CONTRIBUTING.md#coding-conventions to drop the +1.63.0.
|
Chatted offline. Approach doesn't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure that cargo fmt effects remain equal to what the rustfmt CI job expects.