Skip to content

Conversation

@andrei-21
Copy link
Contributor

No description provided.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Oct 25, 2025

I've assigned @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.80%. Comparing base (be24841) to head (32a33ac).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/onion_message/dns_resolution.rs 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4174      +/-   ##
==========================================
- Coverage   88.81%   88.80%   -0.01%     
==========================================
  Files         180      180              
  Lines      137105   137101       -4     
  Branches   137105   137101       -4     
==========================================
- Hits       121765   121751      -14     
- Misses      12529    12534       +5     
- Partials     2811     2816       +5     
Flag Coverage Δ
fuzzing 21.59% <0.00%> (+<0.01%) ⬆️
tests 88.64% <90.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheBlueMatt TheBlueMatt merged commit 6941b0a into lightningdevkit:main Oct 25, 2025
22 of 25 checks passed
@andrei-21 andrei-21 deleted the feature/clean-predicates branch October 25, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants