-
Couldn't load subscription status.
- Fork 421
[0.2] Pin syn for yet another MSRV breakage #4177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.2] Pin syn for yet another MSRV breakage #4177
Conversation
|
I've assigned @wpaulino as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 0.2 #4177 +/- ##
==========================================
+ Coverage 88.77% 88.80% +0.03%
==========================================
Files 180 180
Lines 136626 136626
Branches 136626 136626
==========================================
+ Hits 121288 121332 +44
+ Misses 12531 12497 -34
+ Partials 2807 2797 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8c4aa07 to
76f0f5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like we also need to do this for the downstream no-std crate build, and the msrv-no-dev-deps-check... this below passes on my machine on 1.63
diff --git a/ci/ci-tests.sh b/ci/ci-tests.sh
index c21c1e0e7..a0b54465a 100755
--- a/ci/ci-tests.sh
+++ b/ci/ci-tests.sh
@@ -124,6 +124,7 @@ cargo test -p lightning-invoice --verbose --color always --no-default-features -
echo -e "\n\nTesting no_std build on a downstream no-std crate"
# check no-std compatibility across dependencies
pushd no-std-check
+[ "$RUSTC_MINOR_VERSION" -lt 68 ] && cargo update -p syn --precise "2.0.106" --verbose
cargo check --verbose --color always
[ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
popd
@@ -131,6 +132,7 @@ popd
# Test that we can build downstream code with only the "release pins".
pushd msrv-no-dev-deps-check
PIN_RELEASE_DEPS
+[ "$RUSTC_MINOR_VERSION" -lt 68 ] && cargo update -p syn --precise "2.0.106" --verbose
cargo check
[ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
popd76f0f5b to
12c52c7
Compare
|
Grr, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failures seem unrelated
| cd fuzz && cargo update -p regex --precise "1.9.6" --verbose | ||
| cd write-seeds && cargo update -p regex --precise "1.9.6" --verbose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making sure the --verbose delete here was intentional ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, seemed useless.
No description provided.