Skip to content

Small API tweaks to make bindings easier #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 30, 2025
Merged

Small API tweaks to make bindings easier #4186

merged 3 commits into from
Oct 30, 2025
+21 −22

Conversation

@TheBlueMatt
Copy link
Collaborator

No description provided.

@TheBlueMatt TheBlueMatt added this to the 0.2 milestone Oct 29, 2025
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Oct 29, 2025 •
edited
Loading

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@TheBlueMatt TheBlueMatt requested a review from tnull October 29, 2025 19:08
@TheBlueMatt TheBlueMatt force-pushed the 2025-10-first-bindings-pass branch from 7e9c8ff to d9426a3 Compare October 29, 2025 21:03
@codecov
Copy link

codecov bot commented Oct 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.83%. Comparing base (afb80e5) to head (e4512d1).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/util/anchor_channel_reserves.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4186      +/-   ##
==========================================
- Coverage   88.86%   88.83%   -0.04%     
==========================================
  Files         180      180              
  Lines      137869   137873       +4     
  Branches   137869   137873       +4     
==========================================
- Hits       122520   122480      -40     
- Misses      12539    12581      +42     
- Partials     2810     2812       +2
Flag Coverage Δ
fuzzing 21.44% <0.00%> (+0.58%) ⬆️
tests 88.68% <77.77%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tnull
tnull reviewed Oct 30, 2025
View reviewed changes
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to do the first commit. No strong opinions on the others, though generally not sure if it's worth the last-minute API churn.

lightning-liquidity/src/lsps5/event.rs
/// - `"x-lsps5-timestamp"`: with the timestamp in RFC3339 format (`"YYYY-MM-DDThh:mm:ss.uuuZ"`).
/// - `"x-lsps5-signature"`: with the signature of the notification payload, signed using the LSP's node ID.
/// Other custom headers may also be included as needed.
headers: HashMap<String, String>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a HashMap here is more convenient as the go-to reqwest::HeaderMap type offers a simply TryFrom implementation. I guess the change doesn't hurt too much.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lightning::util::hash_tables::HashMap anyway, not an std::collection::HashMap :(

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@TheBlueMatt
Make LSPS5ServiceEvent::SendWebhookNotification::headers a Vec
031a987 
While HTTP headers should be a unique K->V mapping, returning three
headers to a user in an event via a `HashMap` is substantially
overkill (and also not trivial to do in bindings). Instead, we
expose them as a `Vec`.
@TheBlueMatt
Drop WebhookNotification::new in favor of explicit construction
b10a4e8 
`WebhookNotification` already has all fields `pub`, making its
`new` constructor somewhat redundant, but also conflicting with the
bindings-auto-generated `new` constructor. Thus we just drop it.
@TheBlueMatt
Dont pass objects to anchor reserves calculator by ref-ref
e4512d1 
If we're already passing `AChannelManagerRef` and `ChainMonitorRef`
to `can_support_additional_anchor_channel` there's no need to take
them by reference.
@TheBlueMatt TheBlueMatt force-pushed the 2025-10-first-bindings-pass branch from d9426a3 to e4512d1 Compare October 30, 2025 17:29
@TheBlueMatt
Copy link
Collaborator Author

Went ahead and dropped the integer size change for errors.

tnull
tnull approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@tnull tnull left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Simple enough, feel free to land when CI passes.

@TheBlueMatt TheBlueMatt merged commit c90750c into lightningdevkit:main Oct 30, 2025
23 of 25 checks passed
@TheBlueMatt TheBlueMatt mentioned this pull request Oct 30, 2025
Merged
@TheBlueMatt
Copy link
Collaborator Author

Backported to 0.2 in #4193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnull tnull tnull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@TheBlueMatt @ldk-reviews-bot @tnull