Fix new clippy lints
#4195
Merged
Fix new clippy lints
#4195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`clippy` now complains that `Default` for the interactive tx
constructor `StateMachine` can be auto-derived, but its a bit weird
to have a `Default` that loads an invalid ("indeterminate") state.
Instead, we replace the one line that actually cares about the
`Default` (which uses `core::mem::take`) with `core::mem::replace`,
making it more explict.
|
👋 I see @joostjager was un-assigned. |
Merged
|
Backporting to 0.2 in #4193 |
`clippy` now complains about more instances of useless `vec!`s, so we drop them here.
TheBlueMatt
force-pushed
the
2025-10-clippy
branch
from
5507b92 to
3c1159c
Compare
TheBlueMatt
changed the title
StateMachine::default use with core::mem::replaceclippy lints
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4195 +/- ##
==========================================
+ Coverage 88.84% 88.86% +0.01%
==========================================
Files 180 180
Lines 137876 137901 +25
Branches 137876 137901 +25
==========================================
+ Hits 122498 122539 +41
+ Misses 12571 12551 -20
- Partials 2807 2811 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
valentinewallace
approved these changes
Oct 30, 2025
jkczyz
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clippynow complains thatDefaultfor the interactive tx constructorStateMachinecan be auto-derived, but its a bit weird to have aDefaultthat loads an invalid ("indeterminate") state. Instead, we replace the one line that actually cares about theDefault(which usescore::mem::take) withcore::mem::replace, making it more explict.